-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review117667
-----------------------------------------------------------




src/tests/reservation_endpoints_tests.cpp (line 754)
<https://reviews.apache.org/r/42754/#comment178948>

    just for my understanding: the filter does not effect reserved resources 
(as we still expect labeledResource2 to be offered below), correct?



src/tests/resources_tests.cpp (line 1623)
<https://reviews.apache.org/r/42754/#comment178935>

    Shouldn't we also test that different labels are not considered equal?



src/tests/resources_tests.cpp (line 1666)
<https://reviews.apache.org/r/42754/#comment178936>

    Even though this is not done in the rest of the file, a short comment 
explaining the tests intention is helpful and present in other test files. Feel 
free to drop if you disagree.



src/tests/resources_tests.cpp (line 1685)
<https://reviews.apache.org/r/42754/#comment178937>

    see above, short comment of test intention.



src/tests/resources_tests.cpp (line 1740)
<https://reviews.apache.org/r/42754/#comment178938>

    see above. Short comment describing tests intention.



src/tests/resources_tests.cpp (line 1756)
<https://reviews.apache.org/r/42754/#comment178943>

    Isn't this already checked above?



src/tests/resources_tests.cpp (line 1757)
<https://reviews.apache.org/r/42754/#comment178942>

    Checking each time the inverse case seems a little superfluous as both 
Resources only differ in the label. Still not a real issue for me



src/v1/resources.cpp (line 1494)
<https://reviews.apache.org/r/42754/#comment178939>

    Fine with me, but in the case of volume we have one blank line between the 
last `stream <<` and return statement.


- Joerg Schad


On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
>     https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a111154411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
>   src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
>   src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 
>   src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
>   src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
>   src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 
>   src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to