> On Feb. 3, 2016, 8:12 p.m., Jie Yu wrote: > > src/slave/constants.cpp, line 55 > > <https://reviews.apache.org/r/42781/diff/6/?file=1230793#file1230793line55> > > > > I am thinking about whether we should introduce a default here or not. > > > > I think I also want the option that Mesos will just do the cgroups > > creation without assigning handles. > > > > That being said, can we make the flag optional and do not assign > > handles in net_cls cgroup if that flag is not set?
Made the flag optional. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/#review117668 ----------------------------------------------------------- On Feb. 3, 2016, 7:47 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42781/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 7:47 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4344 > https://issues.apache.org/jira/browse/MESOS-4344 > > > Repository: mesos > > > Description > ------- > > Added the --cgroups_net_cls_primary_handle flag to the slave. > > > Diffs > ----- > > src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 > src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 > src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 > src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 > > Diff: https://reviews.apache.org/r/42781/diff/ > > > Testing > ------- > > Tested the flag by launching a mesos agent and checking that the slave takes > the `--cgroups_net_cls_major_handles` flag. > > > Thanks, > > Avinash sridharan > >
