> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do you have already run > `./bootstrap` in local? > > haosdent huang wrote: > Could you check whether `.git/hooks/pre-commit` exist in your local > machine and that `reset --soft` and submit again? Usually it would execute > `support/mesos_split.py` to make sure `the commits are properly split between > mesos, libprocess and stout.`.
yes, it would generate two patches finally. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117771 ----------------------------------------------------------- On Feb. 4, 2016, 7:40 a.m., Andy Pang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43136/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 7:40 a.m.) > > > Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-4577 > https://issues.apache.org/jira/browse/MESOS-4577 > > > Repository: mesos > > > Description > ------- > > Support libprocess build run in aarch64 cpu. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 > src/tests/containerizer/routing_tests.cpp > 4ebb01213ce20f954c2633df95e898cf66a2d9e9 > > Diff: https://reviews.apache.org/r/43136/diff/ > > > Testing > ------- > > test run ok in AArch64. > > > Thanks, > > Andy Pang > >
