> On Feb. 4, 2016, 7:43 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, lines 643-649
> > <https://reviews.apache.org/r/40375/diff/10/?file=1185761#file1185761line643>
> >
> >     This looks like an internal information, the *source* of a revocable 
> > resource. While we definitely need this is the allocator, I'm not sure we 
> > should expose it in the public protobuf. I think frameworks are more 
> > interested in the *quality* of a resource. Can we keep the source private 
> > somehow?

Framework need to know revocable type as master did not allow to use both 
USAGE_SLACK and ALLOCATION_SLACK for one task; it's because the controller 
(QoSController & evicting modules) is different for now.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review117796
-----------------------------------------------------------


On Jan. 7, 2016, 11:43 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 11:43 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
>     https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
>   include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to