> On Feb. 3, 2016, 10:55 p.m., Vinod Kone wrote:
> > src/tests/containerizer.hpp, line 140
> > <https://reviews.apache.org/r/41290/diff/1/?file=1161079#file1161079line140>
> >
> >     s/v1callbacks/v1Callbacks/

Modified it to `v1Executors` now.


> On Feb. 3, 2016, 10:55 p.m., Vinod Kone wrote:
> > src/tests/containerizer.cpp, lines 104-108
> > <https://reviews.apache.org/r/41290/diff/1/?file=1161080#file1161080line104>
> >
> >     move this to #163

As per our offline discussion, we save the container to an existing map after 
we perform this check. If we move this to L163, we might have erroneously 
inserted a container without having an executor to launch it.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review117684
-----------------------------------------------------------


On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
>     https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the `TestContainerizer` class to handle HTTP based 
> executors. Previously, the containerizer test class only used to handle the 
> driver interface.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to