-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43216/#review117922
-----------------------------------------------------------




3rdparty/libprocess/src/help.cpp (lines 146 - 160)
<https://reviews.apache.org/r/43216/#comment179209>

    How about the following?
    
    ```
    {
      "processes":
      [
        { "id": "<ID>", "endpoints": [{"name": "<NAME>", "text": "<TEXT>"}] },
      ]
    }
    ```
    
    Then the consumption code looks like this:
    
    ```
    for process in processes:
      for endpoint in process.endpoints:
        process.id, endpoint.name, endpoint.text
    ```
    
    We might want a comment that shows the format to help the reader of this 
code?


- Ben Mahler


On Feb. 4, 2016, 8:40 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43216/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 8:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Bugs: MESOS-3831
>     https://issues.apache.org/jira/browse/MESOS-3831
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used to dump the help strings into a JSON object when
> hitting the /help endpoint with a specific request for JSON data.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 2e76a6a5b1069abce879374a88cea65036873f1d 
>   3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 
> 
> Diff: https://reviews.apache.org/r/43216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to