----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43217/#review117961 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/help.cpp (line 204) <https://reviews.apache.org/r/43217/#comment179254> Period at the end here? 3rdparty/libprocess/src/help.cpp (lines 206 - 207) <https://reviews.apache.org/r/43217/#comment179253> Looks like we can directly return: ``` return http::OK(jsonify(*this)); ``` - Ben Mahler On Feb. 5, 2016, 3:23 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43217/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 3:23 a.m.) > > > Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. > > > Bugs: MESOS-3831 > https://issues.apache.org/jira/browse/MESOS-3831 > > > Repository: mesos > > > Description > ------- > > Previously, the /help endpoint could only be returned as either pure > markdown or html. > > This commit introduces a query parameter: format=json to allow the > help endpoint to return a JSON object containing the help information > for all other endpoints. > > > Diffs > ----- > > 3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae > > Diff: https://reviews.apache.org/r/43217/diff/ > > > Testing > ------- > > Unit test in a subsequent commit. > > > Thanks, > > Kevin Klues > >
