> On Feb. 5, 2016, 3:14 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 540-543 > > <https://reviews.apache.org/r/43032/diff/4/?file=1232231#file1232231line540> > > > > why not > > > > Try<Nothing> validateVersion = > > docker->validateVersion(Version(1, 6, 0)); > > if (validateVersion.isError()) { > > LOG(WARNING) << "Current docker version does not support > > labels." > > << "So TaskInfo labels are ignored to set as docker" > > << "labels."; > > } else { > > } > > Abhishek Dasgupta wrote: > It looked like it was designed for other purpose where docker version > upgradation is a must, but for this label scenario, I did not think we needed > any hard bound to upgrade to docker higher version. If you suggest we must > use validateVersion, I can make the necessary changes.What do you say??
Ok, as I got suggestion on using validateVersion, I am making the necessary changes. I wanted to use it too, but for that dubious thought inside me, I refrained from using it. Now I can as I have your suggestions with me. Thank you. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117956 ----------------------------------------------------------- On Feb. 4, 2016, 6:18 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43032/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 6:18 p.m.) > > > Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-4446 > https://issues.apache.org/jira/browse/MESOS-4446 > > > Repository: mesos > > > Description > ------- > > Set Docker labels based on TaskInfo labels. > > > Diffs > ----- > > src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 > src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e > src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 > src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 > src/tests/containerizer/docker_containerizer_tests.cpp > 645bdcf095145097d8b8c65d592c787417883145 > src/tests/containerizer/docker_tests.cpp > f0ad20e5a8252ad761e8fa42724caed31b8fae9d > src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b > src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 > > Diff: https://reviews.apache.org/r/43032/diff/ > > > Testing > ------- > > The following test cases in docker_tests have been changed: > DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to > docker run command through arguments. > > > Thanks, > > Abhishek Dasgupta > >
