-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43193/
-----------------------------------------------------------

(Updated Feb. 5, 2016, 10:14 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Added asserts the newly added docker tests env.


Bugs: MESOS-4587
    https://issues.apache.org/jira/browse/MESOS-4587


Repository: mesos


Description
-------

Allow equal character in the value of environemnt variables.


Diffs (updated)
-----

  src/docker/docker.cpp b4b8d3e9e983499bffd6f8f29bb4b71715f737d1 
  src/tests/containerizer/docker_tests.cpp 
f0ad20e5a8252ad761e8fa42724caed31b8fae9d 

Diff: https://reviews.apache.org/r/43193/diff/


Testing
-------

- Start mesos master, slave and marathon, add a marathon task with the docker 
image `jupyter/all-spark-notebook`, the one the reporter has problem to launch 
beacuse it has equal signs in env vars. 
```json
{
  "id": "/testapp/app1",
  "cmd": "env && sleep 30000000000",
  "cpus": 0.1,
  "mem": 18,
  "requirePorts": false,
  "instances": 1,
  "executor": "",
  "container": {
    "type": "DOCKER",
    "docker": {
      "image": "jupyter/all-spark-notebook",
      "network": "BRIDGE",
      "portMappings": [
        {
          "containerPort": 8888,
          "hostPort": 31000,
          "protocol": "tcp"
        }
      ],
      "privileged": false
    }
  }
}
```
- Without this patch, the task fails to launch with:
```sh
E0204 18:04:38.538508 14843 slave.cpp:3703] Container 
'0dd269c4-cdeb-4a24-ae5c-86b75fae8737' for executor 
'testapp_app1.c19685e6-cb69-11e5-99d6-024234e5bbc1' of framework 
aaf4cc37-4809-4495-a9bd-18c1407442e0-0000 failed to start: Unable to create 
image: Unexpected Env format for 'ContainerConfig.Env'
```
  
- With this patch, the task starts successfully.


Thanks,

Shuai Lin

Reply via email to