> On Feb. 1, 2016, 3:51 a.m., Guangya Liu wrote:
> > It is better add some unit tests in `hierarchical_allocator_tests.cpp` to 
> > cover the update in allocator for shareable resources.

Added unit tests but included in https://reviews.apache.org/r/42996.


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42993/#review117177
-----------------------------------------------------------


On Feb. 5, 2016, 10:57 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42993/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 10:57 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The allocator tracks allocated shared resources separately from the
> remaining allocated resources so that multiple frameworks see the
> same view of the shared resource at any given time. This avoids
> unnecessary copies of the same shared resource when multiple
> frameworks use such resources simultaneously.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> a9d2c23162892e22220f97d89a076d2311091d91 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 4669149b81de39b4bb921ef7cd6787aa583f6e40 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 18797e42a9c2bd20392020237cfae600a5ffe12c 
>   src/master/allocator/sorter/sorter.hpp 
> a0a779b81f6d048271f15256b38ff907ae144b83 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
> 
> Diff: https://reviews.apache.org/r/42993/diff/
> 
> 
> Testing
> -------
> 
> make check done.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Reply via email to