> On 二月 5, 2016, 7:07 a.m., Guangya Liu wrote:
> > docs/roles.md, line 21
> > <https://reviews.apache.org/r/43200/diff/2/?file=1232978#file1232978line21>
> >
> >     Maybe `Configure Mesos to provide guaranteed resource allocations for 
> > use by a role.` is better? You can refer to `home.md` to check the 
> > explanation for `quota.md`
> 
> Greg Mann wrote:
>     I like using the word "guaranteed", but I don't think that saying "for 
> use by a role" makes sense when we are actually trying to define what a 
> "role" is. I changed the text to use "guaranteed"; let me know what you think!

My only concern is that the description in `roles.md` and `home.md` will have 
different explanation for `Quota`, I think that we should keep them consistent.

What about update your latest document as "for a group of frameworks in one 
role"?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review117978
-----------------------------------------------------------


On 二月 6, 2016, 2:43 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> -----------------------------------------------------------
> 
> (Updated 二月 6, 2016, 2:43 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
>     https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -----
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to