> On Feb. 6, 2016, 10:11 a.m., Guangya Liu wrote:
> > docs/configuration.md, lines 1679-1682
> > <https://reviews.apache.org/r/43144/diff/5/?file=1236467#file1236467line1679>
> >
> > How about: Libprocess will normally use a thread pool sized according
> > to the number of active CPUs. This can be overridden by setting the
> > LIBPROCESS_MAX_WORKER_THREADS environment variable to the desired thread
> > count. Normally, this will provides an upper bound on the number of worker
> > threads.
The setting is always an upper bound. I tried to follow the same form of the
descriptions of other environment variables "If set, ...".
How about the following?
If set, this provides an upper bound on the size of the
libprocess thread pool. By default, libprocess uses a thread
pool sized according to the number of CPUs, but not less than 8.
- Maged
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review118141
-----------------------------------------------------------
On Feb. 5, 2016, 9:46 p.m., Maged Michael wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 9:46 p.m.)
>
>
> Review request for mesos, Guangya Liu, Klaus Ma, and Qian Zhang.
>
>
> Bugs: MESOS-4353
> https://issues.apache.org/jira/browse/MESOS-4353
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added env var to set upper bound on number of libprocess worker threads.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d8a74d7
> docs/configuration.md 4b5a394
>
> Diff: https://reviews.apache.org/r/43144/diff/
>
>
> Testing
> -------
>
> Passed make check on x86_64 Ubuntu 14.04.
>
> Invocations of mesos-master, mesos-slave, and mesos-tests with the
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0",
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as
> expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively.
> The last 3 tests generated warnings.
>
>
> Thanks,
>
> Maged Michael
>
>
