This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 8, 2016, 10:04 p.m.)

Review request for mesos and Vinod Kone.


Review comments from Vinod

Bugs: MESOS-4614

Repository: mesos


This change fixes the flakiness in this test. The issue was a race between the 
`connected` callback being called before we did `process::spawn` to start the 

The details of the race that lead to the failure are as follows:
- We started the executor library inside the constructor of `TestExecutor`. The 
callback function did `process::defer(self(), &Self::connected)`
- The `connected` callback can be invoked by the Executor library before we got 
a chance to actually invoke `process::spawn` on the `TestExecutor` process 
itself. This in can turn lead to the `dispatch` being silently dropped.

This change now starts the library inside the `initialize` function that is 
gurranteed to be called after `process::spawn` is invoked.

Diffs (updated)

  src/examples/test_http_executor.cpp 4916e0ebb7215d911556561a8560d78a1192001c 

Diff: https://reviews.apache.org/r/43285/diff/


make check + The flakiness is really easy to reproduce under load:

- Run the tests with `stress --cpu 4 --timeout 120` running in the background.


Anand Mazumdar

Reply via email to