> On Feb. 7, 2016, 9:48 p.m., Anand Mazumdar wrote:
> > src/tests/slave_tests.cpp, line 1339
> > <https://reviews.apache.org/r/43267/diff/1/?file=1236708#file1236708line1339>
> >
> >     Can we just do:
> >     
> >     `TestContainerizer containerizer1;` similar to what we do a few lines 
> > later in this test for `containerizer2` to be consistent?
> >     
> >     Another option can be to modify both the occurences and wrap them in 
> > `process::Owned`. I would prefer the first option since we do so for all 
> > the other tests in this file too.

`containerizer1` was instantiated on the heap because we don't want it to be 
running when the first slave is shutdown. This is the same pattern we follow 
when we restart a slave (see slave_recovery_tests.cpp).


> On Feb. 7, 2016, 9:48 p.m., Anand Mazumdar wrote:
> > src/tests/slave_tests.cpp, line 1357
> > <https://reviews.apache.org/r/43267/diff/1/?file=1236708#file1236708line1357>
> >
> >     Nit: I thought we decided to not do `Times(1)` explicitly in our test 
> > code?

copy paste error. fixed.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/#review118193
-----------------------------------------------------------


On Feb. 5, 2016, 10:46 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43267/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-4066
>     https://issues.apache.org/jira/browse/MESOS-4066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will help operators hitting the /state endpoint by not returning 
> incomplete
> data when slave is still recoverying.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
> 
> Diff: https://reviews.apache.org/r/43267/diff/
> 
> 
> Testing
> -------
> 
> make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"
> 
> ./bin/mesos-tests.sh 
> --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000 
> --gtest_break_on_failure
> 
> ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to