----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/#review118487 -----------------------------------------------------------
src/linux/systemd.cpp (line 76) <https://reviews.apache.org/r/43306/#comment179736> Should you need to do this? Isn't the expectation if a hook fails then `Subprocess` will take care of cleaning up the child? - Benjamin Hindman On Feb. 9, 2016, 7:14 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43306/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 7:14 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Migrated linux launcher systemd executor logic into subprocess hook. > > > Diffs > ----- > > src/linux/systemd.cpp 5034308cb4d1bb0b66c097daf5ec53a880cf510a > src/slave/containerizer/mesos/linux_launcher.cpp > c2e252ec6ed0d6d4c47e244f700315bd340cee5f > > Diff: https://reviews.apache.org/r/43306/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
