> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > <https://reviews.apache.org/r/43321/diff/1/?file=1237111#file1237111line839> > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processed completely?
+1 for add settle > On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 850 > > <https://reviews.apache.org/r/43321/diff/1/?file=1237111#file1237111line850> > > > > Does this still needed? I think still need, we don't sure what would happend in `Shutdown()` in the future. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review118391 ----------------------------------------------------------- On Feb. 8, 2016, 4:20 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43321/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 4:20 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-4175 > https://issues.apache.org/jira/browse/MESOS-4175 > > > Repository: mesos > > > Description > ------- > > Speeded up SchedulerTest.Decline by advancing the clock. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad > > Diff: https://reviews.apache.org/r/43321/diff/ > > > Testing > ------- > > sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/* > > ```sh > [ RUN ] ContentType/SchedulerTest.Decline/0 > [ OK ] ContentType/SchedulerTest.Decline/0 (114 ms) > [ RUN ] ContentType/SchedulerTest.Decline/1 > [ OK ] ContentType/SchedulerTest.Decline/1 (98 ms) > ``` > > > Thanks, > > Shuai Lin > >
