-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/#review118572
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/container_loggers/lib_logrotate.cpp (line 132)
<https://reviews.apache.org/r/43308/#comment179844>

    `&` here as well please?


- Benjamin Hindman


On Feb. 9, 2016, 7:14 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43308/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 7:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added systemd life-extension option to container logrotate module.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 01a3ff031b70366443214e2895803cd4b2606ad8 
> 
> Diff: https://reviews.apache.org/r/43308/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to