-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/#review118573
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/launcher.cpp (line 127)
<https://reviews.apache.org/r/43309/#comment179845>

    `&` here as well please?


- Benjamin Hindman


On Feb. 9, 2016, 7:14 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43309/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 7:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added systemd life-extension option to posix launcher.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> d64832477313de2ef39aa43db67486cfa4023813 
> 
> Diff: https://reviews.apache.org/r/43309/diff/
> 
> 
> Testing
> -------
> 
> make check
> manual testing on systemd with agent-systemd-unit `KillMode=control-group`.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to