> On 二月 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > <https://reviews.apache.org/r/43093/diff/3/?file=1233160#file1233160line307> > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e. prior to your change it did not > > return an error if `HostConfig.NetworkMode` was not set, or am I mistaken? > > Feel free to drop if this is the intended behavior! > > haosdent huang wrote: > `HostConfig.NetworkMode` exists since api > [1.15](https://docs.docker.com/engine/reference/api/docker_remote_api_v1.15/) > I think it's better we use the old way to get ip first. If we get the ip by > old way failed, try use `HostConfig.NetworkMode` and the new way to get ip > again.
+1 to haosdent, we can first use old way to get IP address then if old way failed, use the new way to get IP address. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review118436 ----------------------------------------------------------- On 二月 4, 2016, 9:27 p.m., Travis Hegner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43093/ > ----------------------------------------------------------- > > (Updated 二月 4, 2016, 9:27 p.m.) > > > Review request for mesos, haosdent huang and Kapil Arya. > > > Bugs: MESOS-4370 > https://issues.apache.org/jira/browse/MESOS-4370 > > > Repository: mesos > > > Description > ------- > > Fixes [MESOS-4370] > > > Diffs > ----- > > src/docker/docker.cpp b4b8d3e > > Diff: https://reviews.apache.org/r/43093/diff/ > > > Testing > ------- > > This patch will first query the docker API for the HostConfig.NetworkMode, > which is populated with the network name. (Essentially what was passed in > --net <name> to the docker run command). This name is then used as a key in > NetworkSettings.Networks.<name>.IPAddress to get the IP address that is > currently in use by the container. > > It appears that even though the docker API has been set up to allow for > multiple networks, our testing has indicated that it's still only applying > one network to the container (the last one via the --net argument on the run > line). I can only speculate that the docker API will change again in the near > future, but I can't speculate how, so at least this fixes the problem as it > stands right now. > > Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04. > > > Thanks, > > Travis Hegner > >
