> On 二月 10, 2016, 1:05 p.m., Guangya Liu wrote:
> > src/docker/docker.cpp, line 526
> > <https://reviews.apache.org/r/42516/diff/9/?file=1239370#file1239370line526>
> >
> >     I prefer that we use "higher than" or "greater than" instead of ">=", 
> > we can wait for the comments from Tim.
> 
> Ezra Silvera wrote:
>     The problem is that "higher or equal to" seemed too awkward to me
> 
> Guangya Liu wrote:
>     Just saw that @tnachen already showed his comments above about this and 
> his suggestion is `User network mode requires Docker version higher than 
> 1.9.0`
> 
> Ezra Silvera wrote:
>     The problem is the 1.9.0 is also OK so it's "higher or equal to " which 
> I'm not so happy with :-)
> 
> Guangya Liu wrote:
>     What about `User network mode requires Docker version not smaller than 
> 1.9.0` ?
> 
> Ezra Silvera wrote:
>     "User defined networks require Docker version 1.9.0 or higher"

This looks better, thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review118633
-----------------------------------------------------------


On 二月 10, 2016, 8:34 a.m., Ezra Silvera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -----------------------------------------------------------
> 
> (Updated 二月 10, 2016, 8:34 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
>     https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Signed-off-by: Ezra Silvera <e...@il.ibm.com>
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> -------
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork...."
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Reply via email to