----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43438/ -----------------------------------------------------------
(Updated Feb. 11, 2016, 11:33 a.m.) Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Changes ------- Move a FUTURE_DISPATCH on the MesosContainerizer after the destruction of a prior containerizer. Bugs: MESOS-4633 https://issues.apache.org/jira/browse/MESOS-4633 Repository: mesos Description ------- Makes the following changes: * All objects passed to `StartSlave` are transformed into `shared_ptr`. * References to the above objects are updated to reflect the different type. * Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated dependency. * Removes manual `delete`s inside tests. * Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and `dockerContainerizer` -> `containerizer`). * Removes extraneous spaces in `Try<PID<Slave> >` in touched lines. Diffs (updated) ----- src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145 src/tests/containerizer/external_containerizer_test.cpp 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 src/tests/containerizer/filesystem_isolator_tests.cpp d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660 src/tests/containerizer/memory_pressure_tests.cpp 4a03af2c9c0643d964b1d76e2096341b59bf5dce src/tests/containerizer/mesos_containerizer_tests.cpp 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 src/tests/containerizer/port_mapping_tests.cpp aa9846097feda1a82131b67aa4c782ec3625d049 Diff: https://reviews.apache.org/r/43438/diff/ Testing ------- Tests are run at the very, very end of this review chain. Thanks, Joseph Wu