----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43483/#review118877 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 415) <https://reviews.apache.org/r/43483/#comment180220> No need for the quote. ``` Updating container status with net_cls.classid " << hexify(info.handle->get()). ``` Also, I think we should add a streaming function for NetClsHandle so that we can do: ``` << info.handle.get() ``` here. src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 473) <https://reviews.apache.org/r/43483/#comment180215> s/Allocating/Allocated/ src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 474) <https://reviews.apache.org/r/43483/#comment180195> Remove ':'. - Jie Yu On Feb. 11, 2016, 3:35 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43483/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 3:35 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4657 > https://issues.apache.org/jira/browse/MESOS-4657 > > > Repository: mesos > > > Description > ------- > > Added logs for better debugging of allocation of `net_cls` handles. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > 2fc79973524d3776d39d378f22ac694030347c73 > > Diff: https://reviews.apache.org/r/43483/diff/ > > > Testing > ------- > > make and make check > > > Thanks, > > Avinash sridharan > >
