> On Feb. 10, 2016, 12:19 a.m., Michael Park wrote:
> > include/mesos/type_utils.hpp, line 71
> > <https://reviews.apache.org/r/42754/diff/6/?file=1235807#file1235807line71>
> >
> >     We should keep the 2 newlines here. There are other parts that need 2 
> > lines also, for example between `bool operator!=(const TaskStatus& left, 
> > const TaskStatus& right);` and `inline bool operator==(const ContainerID& 
> > left, const ContainerID& right)`.
> 
> Neil Conway wrote:
>     What is the rationale for keeping the two lines? It doesn't seem 
> consistent with the spacing in the rest of the file.
>     
>     I fixed the second whitespace issue you mentioned.

Synced with Neil on this. I don't quite know the rationale for keeping __2__ 
newlines, but we use 2 newlines when we need "spacing" in the namespace scope, 
whereas we use 1 newline when we need "spacing" in a class scope. We need 
spacing when either of 2 declarations span multiple lines.

e.g.

```cpp
namespace X {

void F();
void G();

}  // namespace X {
```

```cpp
namespace X {

void F(
    SomeReallyReallyLongType someReallyReallyLongName,
    SomeReallyReallyLongType someReallyReallyLongName);
    
    
void G();

}  // namespace X {
```


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review118506
-----------------------------------------------------------


On Feb. 10, 2016, 6:59 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 6:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
>     https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a111154411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
>   src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 
>   src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
>   src/tests/reservation_endpoints_tests.cpp 
> 0a8c479b6684a4497f53c81c198bfcf8e879aa54 
>   src/tests/resources_tests.cpp a190cc3900be72031e1c13e5843245f0f82dbf99 
>   src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 
>   src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to