-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43487/#review118994
-----------------------------------------------------------



Thanks Abhishek!

Please also do the following in this patch:

* Add gauges for `tasks_killing`. See src/master/metrics.hpp and 
src/slave/metrics.hpp and compare with `tasks_running`.


include/mesos/mesos.proto (line 1111)
<https://reviews.apache.org/r/43487/#comment180291>

    Let's put this up with the other non-terminal states, so right above 
TASK_FINISHED.



include/mesos/v1/mesos.proto (line 1110)
<https://reviews.apache.org/r/43487/#comment180292>

    ditto here


- Ben Mahler


On Feb. 11, 2016, 5:11 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43487/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 5:11 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
>     https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add TASK_KILLING state.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/master/http.cpp 3d7a624b78fd85a8d99bce609e37411ed660678c 
> 
> Diff: https://reviews.apache.org/r/43487/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to