----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/#review118998 -----------------------------------------------------------
src/tests/log_tests.cpp (line 1868) <https://reviews.apache.org/r/43524/#comment180297> How about change to `Seconds(1)`? Because worst case is 1 seconds? And do you think it's necessary to add `Clock::settle()` before `Clock::advance()`? And a comment about why advance here also would be better, because `Seconds(1)` is a magic number. - haosdent huang On Feb. 12, 2016, 10:35 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43524/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 10:35 a.m.) > > > Review request for mesos and haosdent huang. > > > Bugs: MESOS-4160 > https://issues.apache.org/jira/browse/MESOS-4160 > > > Repository: mesos > > > Description > ------- > > Speeded up RecoverTest.AutoInitialization by advacing the clock. > > > Diffs > ----- > > src/tests/log_tests.cpp 923d71f48e743a77f2a3ba9e982aef4417c6c7fe > > Diff: https://reviews.apache.org/r/43524/diff/ > > > Testing > ------- > > `$ sudo make check -j2 GTEST_FILTER='RecoverTest.AutoInitialization'` > > ```sh > [----------] 1 test from RecoverTest > [ RUN ] RecoverTest.AutoInitialization > [ OK ] RecoverTest.AutoInitialization (630 ms) > [----------] 1 test from RecoverTest (631 ms total) > ``` > > > Thanks, > > Shuai Lin > >
