> On Feb. 12, 2016, 7:05 p.m., Jie Yu wrote: > > we should ignore the comment lines, instead of relax this check
No, the comment is at the end of the "nameserver" line, not separated. - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/#review119065 ----------------------------------------------------------- On Feb. 12, 2016, 6:57 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43535/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 6:57 p.m.) > > > Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, Jie Yu, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > It is valid to contain comments in /etc/resolv.conf, so the quickest fix for > this is to relax the ASSERT. > > > Diffs > ----- > > src/tests/containerizer/port_mapping_tests.cpp > aa9846097feda1a82131b67aa4c782ec3625d049 > > Diff: https://reviews.apache.org/r/43535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Cong Wang > >
