----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43546/#review119100 -----------------------------------------------------------
Fix it, then Ship it! src/common/command_utils.hpp (line 79) <https://reviews.apache.org/r/43546/#comment180363> s/compress/gzip/ No need for the note above. Please move the TODO of supporting output file here. src/common/command_utils.hpp (line 84) <https://reviews.apache.org/r/43546/#comment180383> Please move the TODO here and kill this NOTE. src/common/command_utils.hpp (line 88) <https://reviews.apache.org/r/43546/#comment180382> s/uncompress/decompress/ src/tests/common/command_utils_tests.cpp (line 253) <https://reviews.apache.org/r/43546/#comment180384> Insert a new line above. src/tests/common/command_utils_tests.cpp (line 258) <https://reviews.apache.org/r/43546/#comment180386> insert a new line above src/tests/common/command_utils_tests.cpp (lines 270 - 271) <https://reviews.apache.org/r/43546/#comment180385> I would rephrase this: ``` Append the ".gz" suffix since gzip expects that. ``` - Jie Yu On Feb. 12, 2016, 9:44 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43546/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 9:44 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added support for GZIP compress and uncompress. > > > Diffs > ----- > > src/common/command_utils.hpp 738c309eac6bb2dffd517298a5105d23fc9bf371 > src/common/command_utils.cpp 68b7facf62b867ac831ae616dad6623ac271110e > src/tests/common/command_utils_tests.cpp > 9207a1bd6e53a8094db47ddecdcb9d39089c4c51 > > Diff: https://reviews.apache.org/r/43546/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
