-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41760/
-----------------------------------------------------------
(Updated Feb. 13, 2016, 6:24 a.m.)
Review request for mesos, Anand Mazumdar and Kapil Arya.
Changes
-------
Addressed review's comment
Summary (updated)
-----------------
Add initialization method to Anonymous class.
Bugs: MESOS-4253
https://issues.apache.org/jira/browse/MESOS-4253
Repository: mesos
Description (updated)
-------
Jira: MESOS-4253
To provide a basic "context" to anonymous modules, we provide
an `initialize(const FlagsBase&)` method that will be invoked
shortly after creation of the module class.
Diffs (updated)
-----
include/mesos/module/anonymous.hpp 629eb123b9d5fa9e07ddb1c704ee72e96e8fec5b
src/examples/test_anonymous_module.hpp
3da33a42f04b7421cee8fbb85e29b66e352f5894
src/examples/test_anonymous_module.cpp
dd291cff3b5d47337e371cd2c1082fd6716af3fc
src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64
src/tests/anonymous_tests.cpp bc29ff8be94af82dd97f43db4f9594036705e835
src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8
src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a
Diff: https://reviews.apache.org/r/41760/diff/
Testing
-------
Unit tests pass.
Also implemented in the
[execute-module](http://github.com/massenz/execute-module) - and it works there
too:
```
I0102 17:38:26.180788 19971 main.cpp:272] Initializing anonymous module
'com_alertavert_mesos_RemoteExecution'
I0102 17:38:26.180800 19971 main.cpp:278] Sending flags to module
'com_alertavert_mesos_RemoteExecution'
I0102 17:38:26.180810 19971 execute_module.hpp:129] Executing initialize() for
module; parsing runtime flags
I0102 17:38:26.181658 19971 execute_module.hpp:139] Configured work dir to
[/tmp/agent] and Sandbox dir to [/mnt/mesos/sandbox]
```
Thanks,
Marco Massenzio
