-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43565/#review119201
-----------------------------------------------------------




src/slave/containerizer/composing.cpp (line 230)
<https://reviews.apache.org/r/43565/#comment180474>

    It is already 81 chars, it is better to split this to several lines.



src/slave/containerizer/composing.cpp (line 513)
<https://reviews.apache.org/r/43565/#comment180475>

    I was that mesos containizers are using `return Failure("Unknown container: 
" + stringify(containerId));` , can you please update the message to keep 
consistent?


- Guangya Liu


On 二月 14, 2016, 4:31 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43565/
> -----------------------------------------------------------
> 
> (Updated 二月 14, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
>     https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This method will be used by the agent to retrieve `ContainerStatus`
> from the `Containerizer`, that was responsible for launching the
> container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.cpp 
> f0a7bba4a56702872c9b73a12128b5292708d0e7 
> 
> Diff: https://reviews.apache.org/r/43565/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to