> On Feb. 16, 2016, 3:02 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 422
> > <https://reviews.apache.org/r/43367/diff/4/?file=1239305#file1239305line422>
> >
> >     In some fetcher cache tests, we specifically want to find out if 
> > concurrent execution of launching taks works. Settling the clock serializes 
> > this and thus disables some of desired the testing.
> >     
> >     How about shortening the allocation interval and not playing with the 
> > clock?
> 
> haosdent huang wrote:
>     Got it, how about change to 500ms?

Worth a try :-)


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119293
-----------------------------------------------------------


On Feb. 16, 2016, 3:42 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 3:42 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4628
>     https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up FetcherCache test cases by advance allocation_interval.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> -------
> 
> Before this patch:
> ```
> [       OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [       OK ] FetcherCacheTest.LocalCached (1728 ms)
> [       OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [       OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [       OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [       OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
> 
> After this patch:
> ```
> [       OK ] FetcherCacheTest.LocalUncached (984 ms)
> [       OK ] FetcherCacheTest.LocalCached (1750 ms)
> [       OK ] FetcherCacheTest.CachedFallback (1043 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
> [       OK ] FetcherCacheTest.SimpleEviction (2723 ms)
> [       OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
> [       OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
> [       OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to