-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43608/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 6:12 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
-------

Add explanation in testing done.


Bugs: MESOS-4685
    https://issues.apache.org/jira/browse/MESOS-4685


Repository: mesos


Description
-------

Speed up FetcherCache test cases by disable framework checkpoint.


Diffs
-----

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43608/diff/


Testing (updated)
-------

When we enable checkpoint for frameworks, StatusUpdateManager would waiting for 
write StatusUpdateRecord to file and then boardcast it. This cause uncessary 
disk operations and bring unstable delay if our test cases don't depends on 
recovery.  

Before
```
[       OK ] FetcherCacheTest.LocalUncached (2645 ms)
[       OK ] FetcherCacheTest.LocalCached (2653 ms)
[       OK ] FetcherCacheTest.CachedFallback (1110 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (2620 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (2758 ms)
[       OK ] FetcherCacheTest.SimpleEviction (5059 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2648 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3661 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2600 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (2013 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1746 ms)
```

After
```
[       OK ] FetcherCacheTest.LocalUncached (2580 ms)
[       OK ] FetcherCacheTest.LocalCached (2516 ms)
[       OK ] FetcherCacheTest.CachedFallback (957 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
[       OK ] FetcherCacheTest.SimpleEviction (4532 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2579 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3528 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2520 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1534 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1345 ms)
```

And test the recovery test manually:
```
./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Reply via email to