----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119436 -----------------------------------------------------------
src/tests/fetcher_cache_tests.cpp (lines 194 - 196) <https://reviews.apache.org/r/43367/#comment180810> // In some fetcher cache tests, we want to find out if concurrent execution of // launching taks works, settling the clock will serializes this, thus we prefer to // reduce `allocation_interval` to speed up test cases here. - Guangya Liu On 二月 17, 2016, 9:54 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43367/ > ----------------------------------------------------------- > > (Updated 二月 17, 2016, 9:54 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd > Mathiske. > > > Bugs: MESOS-4628 > https://issues.apache.org/jira/browse/MESOS-4628 > > > Repository: mesos > > > Description > ------- > > Speed up FetcherCache test cases by reduce allocation_interval. > > > Diffs > ----- > > src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f > > Diff: https://reviews.apache.org/r/43367/diff/ > > > Testing > ------- > > In this patch, we use 500ms instead of the default allocation_interval 1s. If > the test cases depends on getting offers from master multiple times, this > patch could reduce the offer waiting time and speed up them. > > Before > ``` > [ OK ] FetcherCacheTest.LocalUncached (943 ms) > [ OK ] FetcherCacheTest.LocalCached (1612 ms) > [ OK ] FetcherCacheTest.CachedFallback (906 ms) > [ OK ] FetcherCacheTest.LocalUncachedExtract (940 ms) > [ OK ] FetcherCacheTest.LocalCachedExtract (1719 ms) > [ OK ] FetcherCacheTest.SimpleEviction (3635 ms) > [ OK ] FetcherCacheTest.FallbackFromEviction (2518 ms) > [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms) > [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms) > [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms) > [ OK ] FetcherCacheHttpTest.HttpMixed (1129 ms) > > ``` > > After > ``` > [ OK ] FetcherCacheTest.LocalUncached (979 ms) > [ OK ] FetcherCacheTest.LocalCached (1510 ms) > [ OK ] FetcherCacheTest.CachedFallback (853 ms) > [ OK ] FetcherCacheTest.LocalUncachedExtract (816 ms) > [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms) > [ OK ] FetcherCacheTest.SimpleEviction (2720 ms) > [ OK ] FetcherCacheTest.FallbackFromEviction (2119 ms) > [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms) > [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms) > [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms) > [ OK ] FetcherCacheHttpTest.HttpMixed (1106 ms) > ``` > > > Thanks, > > haosdent huang > >
