----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43489/#review119568 -----------------------------------------------------------
I see you send TASK_KILLING once the killTask() is invoked. However, according to the description of MESOS-4140, we may need to send such status update after SIGTERM is sent to the task and before SIGKILL is sent. So maybe you should send TASK_KILLING in shutdown() instead? - Qian Zhang On Feb. 16, 2016, 6:23 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43489/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 6:23 p.m.) > > > Review request for mesos, Ben Mahler and Qian Zhang. > > > Bugs: MESOS-4547 > https://issues.apache.org/jira/browse/MESOS-4547 > > > Repository: mesos > > > Description > ------- > > KillTask introduces TASK_KILLING state. > > > Diffs > ----- > > src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 > src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 > > Diff: https://reviews.apache.org/r/43489/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Abhishek Dasgupta > >
