-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/#review119575
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43657, 43658, 43659, 43660, 43661, 43662, 43664, 43667]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 10:46 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43667/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3570
>     https://issues.apache.org/jira/browse/MESOS-3570
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the existing tests to handle the new 
> `connected/disconnected` semantics that were introduced as a result of the 
> pipelining change.
> 
> Now `connected` is possible to invoked more then once i.e. during test 
> shutdown, the master closed the event stream making us call the 
> `disconnected` callback. However, the master detector can still detect the 
> same master and establish a connection to it while it is shutting down 
> leading to `connected` callback be invoked again in some cases.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43667/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to