----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/#review119619 -----------------------------------------------------------
3rdparty/libprocess/src/subprocess.cpp (line 303) <https://reviews.apache.org/r/43271/#comment180969> I know which vars you mean here, but other readers won't know. I suggest to name them explicitly. 3rdparty/libprocess/src/subprocess.cpp (line 382) <https://reviews.apache.org/r/43271/#comment180971> Breaking out subprocess_environment but not the code below as a subroutine looks unbalanced. Why not factor the whole affair into a common subroutine together? This routine may look like a filter function: env -> env. - Bernd Mathiske On Feb. 5, 2016, 3:25 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43271/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 3:25 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till > Toenshoff. > > > Bugs: MESOS-4609 > https://issues.apache.org/jira/browse/MESOS-4609 > > > Repository: mesos > > > Description > ------- > > * Adds a helper method for getting the current environment plus > considerations for libprocess. > * Changes the default behavior of `process::subprocess` to use the above > helper when given `environment = None()`. > * Adds a warning inside `process::subprocess` if `LIBPROCESS_PORT` conflicts > with the current process's `LIBPROCESS_PORT`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > bb50cc3070245a294fa16efe44f14ae893bc5518 > 3rdparty/libprocess/src/subprocess.cpp > ff477e37a9619c780bddd5a8e629fa981b729715 > > Diff: https://reviews.apache.org/r/43271/diff/ > > > Testing > ------- > > make > > Tests are run in the next review. > > > Thanks, > > Joseph Wu > >
