-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review119698
-----------------------------------------------------------


Fix it, then Ship it!




Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations).


src/tests/master_maintenance_tests.cpp (lines 61 - 66)
<https://reviews.apache.org/r/43518/#comment181034>

    Instead of importing these default constants, use 
`SlaveFlags::executor_shutdown_grace_period` and 
`MasterFlags::allocation_interval`.
    
    You'll need to slightly modify the `StartMaster` and `StartSlave` calls.
    
    i.e.
    ```
      // NOTE: We don't use `StartMaster()` because we need to access these 
flags.
      master::Flags flags = CreateMasterFlags();
    ```



src/tests/master_maintenance_tests.cpp (line 693)
<https://reviews.apache.org/r/43518/#comment181035>

    Once you change the above, this will look like 
`Clock::advance(slaveFlags.executor_shutdown_grace_period);`.


- Joseph Wu


On Feb. 11, 2016, 10:41 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43518/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4168
>     https://issues.apache.org/jira/browse/MESOS-4168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up MasterMaintenanceTest.EnterMaintenanceMode.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43518/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to