----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43519/#review119700 -----------------------------------------------------------
Fix it, then Ship it! Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations). src/tests/master_maintenance_tests.cpp (line 1218) <https://reviews.apache.org/r/43519/#comment181036> Use the `MasterFlags::allocation_interval` here instead of a default constant. (See comment in previous review.) src/tests/master_maintenance_tests.cpp (line 1273) <https://reviews.apache.org/r/43519/#comment181037> Ditto here. - Joseph Wu On Feb. 11, 2016, 10:41 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43519/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 10:41 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4169 > https://issues.apache.org/jira/browse/MESOS-4169 > > > Repository: mesos > > > Description > ------- > > Speed up MasterMaintenanceTest.InverseOffers. > > > Diffs > ----- > > src/tests/master_maintenance_tests.cpp > b98eedec388813ee795dd83ccc5ff27338209475 > > Diff: https://reviews.apache.org/r/43519/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
