----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119822 -----------------------------------------------------------
Thanks for putting this together. Just a couple of questions. include/mesos/mesos.proto (line 1600) <https://reviews.apache.org/r/43616/#comment181172> Is it ok for labels to contain duplicate keys even if the values are different? That sounds like undefined behavior too. Is the label-consumer supposed to use all values, first value, last value? include/mesos/mesos.proto (line 1634) <https://reviews.apache.org/r/43616/#comment181173> Are you intentionally leaving out the Labels field in DiscoveryInfo, Port, NetworkInfo, Image.Appc? I didn't think Mesos interpreted any of these either. - Adam B On Feb. 17, 2016, 10:44 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43616/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 10:44 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > The implementation of the equality operator for `Labels` is buggy for labels > that contain duplicates. We might want to revisit fixing the implementation of > that operator (which might be expensive; MESOS-4445), but in the short-term we > should document that duplicates should not be specified. > > > Diffs > ----- > > include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 > include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 > > Diff: https://reviews.apache.org/r/43616/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
