----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review119858 -----------------------------------------------------------
First pass. Sorry, did not get through it in one seating. src/tests/cluster.hpp (line 77) <https://reviews.apache.org/r/43613/#comment181250> s/ / / Here and in other places in this patch. Note that we only use one blank after a full stop everywhere else in the code base. src/tests/cluster.hpp (line 154) <https://reviews.apache.org/r/43613/#comment181251> Slightly unclear which is which. Attempt to clarify: ... Once this method has been called, its receiver will no longer perform cleanup in its destructor. Vernacular alternative: ... When this method is called, this wrapper instance will no longer perform cleanup during its destruction. src/tests/cluster.hpp (line 159) <https://reviews.apache.org/r/43613/#comment181252> See above. src/tests/cluster.hpp (line 181) <https://reviews.apache.org/r/43613/#comment181253> What do you mean by "only"? Does it make more sense if you erase that word? src/tests/cluster.hpp (line 188) <https://reviews.apache.org/r/43613/#comment181255> How would a pointer manage anything? src/tests/cluster.cpp (line 101) <https://reviews.apache.org/r/43613/#comment181257> s/NOTE: // no need to be dramatic about this little tidbit :-) s/lambda/extra/ src/tests/cluster.cpp (line 136) <https://reviews.apache.org/r/43613/#comment181258> I think you can keep the first clause on the same line, then align underneath. - Bernd Mathiske On Feb. 17, 2016, 12:27 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43613/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 12:27 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem > Harutyunyan. > > > Bugs: MESOS-4633 and MESOS-4634 > https://issues.apache.org/jira/browse/MESOS-4633 > https://issues.apache.org/jira/browse/MESOS-4634 > > > Repository: mesos > > > Description > ------- > > Major rewrite of the `tests/cluster` helpers. This strongly ties the scope > of test objects to the test body. > > Changes the `Cluster` class into two RAII objects (`Master` and `Slave`). > The `Slave` object performs cleanup originally found in > `cluster::Slave::stop`. `cluster::Master::start` and `cluster::Slave::start` > were changed to factory methods. > > > Diffs > ----- > > src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 > src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 > > Diff: https://reviews.apache.org/r/43613/diff/ > > > Testing > ------- > > Tests are run at the end of this review chain. > > > Thanks, > > Joseph Wu > >
