> On Feb. 19, 2016, 4:26 p.m., Kevin Klues wrote: > > support/generate-endpoint-help.py, line 147 > > <https://reviews.apache.org/r/43715/diff/3/?file=1258995#file1258995line147> > > > > Actually, I was wrong, when I pull down locally, all of these newlines > > are removed (and they sbouldn't be). > > > > Can you patch things up to reinsert these newlines? If I had commit > > rights, I would just make this trivial change myself before pushing back to > > master. Since I don't though, it would be good to get everything as clean > > as possible before a shepherd takes over. > > > > Other than that, everything looks good now. > > Abhishek Dasgupta wrote: > I am extremely sorry. This was my bad. Somehow, I messed up your patch > and all the newlines were gone. Moreover, there is some weired thing > happenning whenever I try to post-review this particular patch. It says, to > commit the changes on endpoint docs, whereas, the endpoint docs were not yet > modified. Anyway, fixed everything and I pulled again and applied your patch > with my changes. So, this time, I hope everything is right. Thank you for > your patience.
No worries. I wish there was a way for me to easilyjust patch thing sup so we don't have to go back and forth for trivial changes like this :). The only other comment I have is the wording of the summary and description for this paatch, as mentioned in this review: https://reviews.apache.org/r/43328/ I have a feeling whoever commits this back will just fix this, but it's good to know for future reference when submitting something for review to the mesos project. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review119893 ----------------------------------------------------------- On Feb. 19, 2016, 7:46 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43715/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 7:46 p.m.) > > > Review request for mesos, Kevin Klues and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Title for endpoint documentation. > > > Diffs > ----- > > support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 > > Diff: https://reviews.apache.org/r/43715/diff/ > > > Testing > ------- > > This is the patch for support/generate-endpoint-help.py to include the > generated files with titles. > Tested using "rake dev" on a live site. > > > Thanks, > > Abhishek Dasgupta > >
