----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43777/ -----------------------------------------------------------
Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. Bugs: MESOS-4591 https://issues.apache.org/jira/browse/MESOS-4591 Repository: mesos Description ------- Removed unnecessary parameter from validation function. Now that Reserve operations are authorized for particular roles, it is unnecessary to pass the framework's role into the validation function for Reserve operations. The function previously ensured that a framework could only reserve resources for its own role, but this check has been removed. Diffs ----- src/master/http.cpp 248e3d432a756c767fc00ee224101d82c417068c src/master/master.cpp e5aaf67e63996700b2cdcdd04055ad5b04bfb085 src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 Diff: https://reviews.apache.org/r/43777/diff/ Testing ------- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann