> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 811-815 > > <https://reviews.apache.org/r/33174/diff/3/?file=1165089#file1165089line811> > > > > This is done after the container has been launched. We should > > definitely call out the fact that there's a short window after the > > container has been launched before the container's cfs quota is updated. > > During that window, it's not subject to cfs throttling. > > > > Alternatively, we could set `--cpu-period` and `--cpu-quota` during > > launch so that we don't have to worry about that window. > > Steve Niemitz wrote: > Is there a minimum supported version of docker for mesos? Those > parameters were added in docker 1.7 I believe. > > Jie Yu wrote: > Yeah, I think for now, add a TODO should be sufficient. Once we bump the > minimum docker version support, we can address that TODO.
sgtm - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review119738 ----------------------------------------------------------- On Dec. 15, 2015, 8:14 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33174/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 8:14 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2617 > https://issues.apache.org/jira/browse/MESOS-2617 > > > Repository: mesos > > > Description > ------- > > Fix for docker containerizer not configuring CFS quotas correctly. > > It would be nice to refactor all this isolation code in a way that can be > shared between all containerizers, as this is basically just copied from the > CgroupsCpushareIsolator, but that's a much bigger undertaking. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e > > Diff: https://reviews.apache.org/r/33174/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
