-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
-----------------------------------------------------------




src/slave/flags.cpp (line 437)
<https://reviews.apache.org/r/39939/#comment181473>

    I think we need to handle feature interaction with `docker_mesos_image`. 
Currently, we mount unix socket into container; but it'll failed when using TCP 
socket.


- Klaus Ma


On Feb. 22, 2016, 11:35 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 11:35 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
>     https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to