> On Feb. 22, 2016, 5:52 a.m., Klaus Ma wrote: > > docs/high-availability-framework-guide.md, line 202 > > <https://reviews.apache.org/r/43821/diff/1/?file=1263875#file1263875line202> > > > > I'd like to be "The `TASK_KILLING` state is optional; it is intended to > > indicate that the..."
Do you consider this an issue? I tend to suggest that folks use "issues" for things like bugs, necessary improvements, items where the reviewer wants to continue the discussion if the issue is dropped. I dropped this one because I made it the same as the existing writing for TASK_STARTING: ``` The `TASK_STARTING` state is optional and intended primarily for use by ``` > On Feb. 22, 2016, 5:52 a.m., Klaus Ma wrote: > > docs/high-availability-framework-guide.md, line 205 > > <https://reviews.apache.org/r/43821/diff/1/?file=1263875#file1263875line205> > > > > Highlight the behaviour if executor generate `TASK_KILLING` without > > framework's capability: ignore, crash or undefined? Well, the reason I mention the capability is that it's up to the framework to express whether it can process the status update (via the capability). We could say that mesos doesn't do any checking of this, we'll forward the update to the framework at which point the framework should log/expose errors or crash. I omitted it because it seems like this kind of detail belongs closer to the executor API? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43821/#review120114 ----------------------------------------------------------- On Feb. 22, 2016, 5:19 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43821/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 5:19 a.m.) > > > Review request for mesos, Abhishek Dasgupta and Neil Conway. > > > Bugs: MESOS-4547 > https://issues.apache.org/jira/browse/MESOS-4547 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/high-availability-framework-guide.md > 0d9c483985d61b512339f50f395f9360de034e2d > > Diff: https://reviews.apache.org/r/43821/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Ben Mahler > >
