-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120353
-----------------------------------------------------------




3rdparty/cmake/Mesos3rdpartyConfigure.cmake (line 34)
<https://reviews.apache.org/r/43889/#comment181786>

    I suggest order items according to their dictionary orders.



3rdparty/libprocess/cmake/macros/External.cmake (line 34)
<https://reviews.apache.org/r/43889/#comment181785>

    And why we need change `EXTERNAL` macro here? I prososal add a version to 
our leveldb.tar.gz


- haosdent huang


On Feb. 23, 2016, 6:13 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4647
>     https://issues.apache.org/jira/browse/MESOS-4647
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Reply via email to