----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120364 -----------------------------------------------------------
The patch looks good to me. Could you rebase? I want to apply the patch and test with mesos-execute. src/tests/containerizer/provisioner_docker_tests.cpp (line 330) <https://reviews.apache.org/r/43860/#comment181799> Could we do `EXPECT_EQ(2u, imageInfo->layers.size())` ? - Gilbert Song On Feb. 22, 2016, 4:54 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43860/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 4:54 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Bugs: MESOS-4261 and MESOS-4499 > https://issues.apache.org/jira/browse/MESOS-4261 > https://issues.apache.org/jira/browse/MESOS-4499 > > > Repository: mesos > > > Description > ------- > > This is the second step of cleaning/simplying the docker registry puller code. > > The new code uses the uri::Fetcher to download docker manifest and blobs > (instead of writting our own http logic which requires enabling of SSL for > Mesos). > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 5b2d72c22fcbcc379b4901607cf3eb682de66206 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > a239b97557ad20353c67050dbc89ef16da898330 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp > bccbac11113357cf942446604e6cf5d16c3d594b > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 3fcf1471a035e35a2cac22442655ad65a84a9793 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 2f1d3e002140f34c646aab445a419c9c3d712f99 > src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 > src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a > src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e > src/tests/containerizer/provisioner_docker_tests.cpp > 4db6793a21abbb7ea4de0d0fca0431237d38d013 > > Diff: https://reviews.apache.org/r/43860/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
