----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120492 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (lines 25 - 26) <https://reviews.apache.org/r/43879/#comment181959> not yours, but I think that it is better add a blank line between 25 and 26 src/tests/hierarchical_allocator_tests.cpp (lines 2390 - 2391) <https://reviews.apache.org/r/43879/#comment181960> What about `Clock::advance(Seconds(2))` Also want to know why using 2s here? src/tests/hierarchical_allocator_tests.cpp (line 2398) <https://reviews.apache.org/r/43879/#comment181961> I saw that most are using `Seconds(15)` src/tests/hierarchical_allocator_tests.cpp (line 2430) <https://reviews.apache.org/r/43879/#comment181962> Days(365) src/tests/hierarchical_allocator_tests.cpp (line 2435) <https://reviews.apache.org/r/43879/#comment181963> Why using double here? Should not this be int? - Guangya Liu On 二月 24, 2016, 10:22 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43879/ > ----------------------------------------------------------- > > (Updated 二月 24, 2016, 10:22 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for number of allocations made. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43879/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
