-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120550
-----------------------------------------------------------



Thanks for the cleanup!


3rdparty/libprocess/include/process/future.hpp (line 791)
<https://reviews.apache.org/r/43461/#comment182020>

    * Mesos currently uses `foreach` from stout rather than range-based`for`.
    * Mesos generally prefers explicit types than `auto`.
    
    ```
    foreach (Future<T> future, futures) {
      ...
    }
    ```
    
    Here and below.


- Michael Park


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 
> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Reply via email to