----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43960/#review120638 -----------------------------------------------------------
src/tests/containerizer/provisioner_docker_tests.cpp (line 343) <https://reviews.apache.org/r/43960/#comment182099> .WillRepeatedly(Return()); // Ignore subsequent offers. src/tests/containerizer/provisioner_docker_tests.cpp (line 348) <https://reviews.apache.org/r/43960/#comment182100> I think here `ASSERT_NE(0u, offers.get().size());` or `ASSERT_EQ(1u, offers.get().size());` may be more accurate src/tests/containerizer/provisioner_docker_tests.cpp (line 359) <https://reviews.apache.org/r/43960/#comment182101> Why you are changing back to `busybox` but not `alpine`? - Guangya Liu On 二月 24, 2016, 6:51 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43960/ > ----------------------------------------------------------- > > (Updated 二月 24, 2016, 6:51 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added an end-to-end test for docker registry puller. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > b3c6f8848f2ceb2bd4dce35d6e7f813c2d4d2bd9 > > Diff: https://reviews.apache.org/r/43960/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
