----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ -----------------------------------------------------------
(Updated Feb. 24, 2016, 6:03 p.m.) Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Changes ------- Rebase and update changes in: * src/tests/executor_http_api_tests.cpp * src/tests/master_maintenance_tests.cpp * src/tests/oversubscription_tests.cpp * src/tests/scheduler_http_api_tests.cpp * src/tests/slave_tests.cpp Bugs: MESOS-4633 and MESOS-4634 https://issues.apache.org/jira/browse/MESOS-4633 https://issues.apache.org/jira/browse/MESOS-4634 Repository: mesos Description ------- Includes the following changes: * Added the `<process/owned.hpp>` header where appropriate. * Added the namespace `using process::Owned;` where appropriate. * Generally replaced `Try<PID<Master>>` with `Owned<cluster::Master>`. And `Try<PID<Slave>>` with `Owned<cluster::Slave>`. * Added the (now required) `MasterDetector` argument to all slaves. Before, this was fetched from the first master in `Cluster`. * Removed `Shutdown();` from all tests. * Replaced `Stop(...)` with the appropriate master/slave destruction calls. * Wrap various slave objects in `Owned` (i.e. containerizers, isolators, launchers, etc). * Replace `CHECK` in tests with `ASSERT`. Diffs (updated) ----- src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/command_executor_tests.cpp 0d2fcf6d4b8d9a925eb6748e6bd33cf279b8f7f8 src/tests/container_logger_tests.cpp 00f4129e46aa9268fbb66da25b34e61004fa87b2 src/tests/containerizer/docker_containerizer_tests.cpp a299c9e0744b5657984e5bb0afbe4874a266ddb6 src/tests/containerizer/external_containerizer_test.cpp 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 src/tests/containerizer/filesystem_isolator_tests.cpp 6a60962b4593b3521c182c7320331743ccffd4ba src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660 src/tests/containerizer/memory_pressure_tests.cpp 4a03af2c9c0643d964b1d76e2096341b59bf5dce src/tests/containerizer/mesos_containerizer_tests.cpp 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 src/tests/containerizer/port_mapping_tests.cpp 983a63333be160aefe5a32acb6111bb3c85230ec src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b src/tests/executor_http_api_tests.cpp 2fc0893f5f5e80a783296fb31b30abe86d92df1b src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a src/tests/hook_tests.cpp 88ad7806bf9f3194e434743c35199a896edea92c src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8 src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_maintenance_tests.cpp c9e3828933d16ec65298e4ad4b1a3e0ddf99032d src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf src/tests/master_validation_tests.cpp ab2df22f73052f6bd77653e56e7b460b17e7b0be src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_endpoints_tests.cpp 6069ca1e9ed278459c5182e438417e95955b1924 src/tests/persistent_volume_tests.cpp e169e1b141a38dc389eefd42c11a078c413123d5 src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 src/tests/registrar_zookeeper_tests.cpp 3df9779ee5d076e16f6a538326693a36f986b6d0 src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da src/tests/reservation_endpoints_tests.cpp 32b2af4115211b58a5127a14dd19152c2eca120c src/tests/reservation_tests.cpp b8878d51767ac0d95e346c44c0a4d5c060e565ef src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 src/tests/scheduler_driver_tests.cpp f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp 428e12646d80b45daec30cfe607b97f36170fdf5 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 src/tests/status_update_manager_tests.cpp d64d3b8c96270478f6b681c038de77c3a9eb68fe src/tests/teardown_tests.cpp 5753559003d703138d2bbee6a1ac93473ba0b0c0 Diff: https://reviews.apache.org/r/43615/diff/ Testing (updated) ------- sudo make check | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 | Non-SSL | :) | :) | %* | :) | :) | :) | :) | With-SSL | :) | :) | * | :) | :) | :) | :) | :) = Passed. * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes % = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery Thanks, Joseph Wu